build: update package.json entries with explicit mjs / mts extensions#565
build: update package.json entries with explicit mjs / mts extensions#565michaelfaith merged 3 commits intomainfrom
Conversation
Following rolldown/tsdown#517, `fixedExtension` is now on by default for node applications, which means that everything that it's emitting `mjs` for any esm js files and `.d.mts` for esm type declarations.
|
👋 Hi @michaelfaith, thanks for the pull request! A scan flagged some concerns with it. Could you please take a look? [pr-task-completion] This PR's body is missing
Repositories often provide a set of tasks that pull request authors are expected to complete. Those tasks should be marked as completed with a [pr-linked-issue] This pull request is not linked as closing any issues. This repository keeps to GitHub issues for discussing potential changes. Most or all changes should be marked as approved in an issue before a pull request is sent to resolve them. To resolve this report:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
=======================================
Coverage 94.17% 94.17%
=======================================
Files 34 34
Lines 756 756
Branches 240 240
=======================================
Hits 712 712
Misses 34 34
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎉 This is included in version v0.59.0 🎉 The release is available on: Cheers! 📦🚀 |
PR Checklist
status: accepting prsOverview
(This was failing in the renovate PR: https://github.com/JoshuaKGoldberg/package-json-validator/pulls)
Following rolldown/tsdown#517,
fixedExtensionis now on by default when the platform is node, which means that it's emittingmjsfor any esm js files and.d.mtsfor esm ts files.